lkml.org 
[lkml]   [2012]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pinctrl: Include <linux/bug.h> to prevent compile errors
On 03/12/2012 01:44 PM, Linus Walleij wrote:
> On Fri, Mar 9, 2012 at 9:18 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>
>> Macros in <linux/pinctrl/machine.h> call ARRAY_SIZE(), the definition of
>> which eventually calls BUILD_BUG_ON_ZERO(), which is defined in
>> <linux/bug.h>. Include that so that every .c file using the pinctrl macros
>> doesn't have to do that itself.
>
> I get this part...
...
>> diff --git a/include/linux/pinctrl/machine.h b/include/linux/pinctrl/machine.h
...
>> -#include "pinctrl-state.h"
>
> ?
>
>> +#include <linux/bug.h>
>> +
>> +#include "pinctrl.h"
>
> ?
>
> But I moved the states out of machine.h and pinctrl.h just so
> that we shouldn't have to include pinctrl.h into machine.h?

Oops. Looks like I completely screwed up a rebase there.

If Paul acks the concept of the patch, I'll repost.


\
 
 \ /
  Last update: 2012-03-12 21:59    [W:0.290 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site