Messages in this thread | | | Date | Mon, 12 Mar 2012 20:37:44 +0100 | Subject | Re: [PATCH 2/3] led-triggers: use atomic kzalloc during led trigger registering | From | Linus Walleij <> |
| |
2012/3/10 Bryan Wu <bryan.wu@canonical.com>: > 2012/3/8 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: >> On Thu, Mar 08, 2012 at 05:11:02PM +0800, Bryan Wu wrote: >>> kzalloc might cause sleep and will generate some warning detected by lockdep, >>> when call led_trigger_register_simple on each cpu cores in SMP. This patch fix >>> this. >> The obvious (and IMHO better) alternative is to call >> led_trigger_register_simple from non-atomic context. >> >> For registering this should be OK, shouldn't it? >> > Thanks Uwe, it's my bad. I think I should not use on_each_cpu() API to > run led_trigger_register_simple. on_each_cpu() will disable interrupt.
It might have been my mistake even so not your fault ... :-)
Thanks, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |