Messages in this thread | | | Date | Mon, 12 Mar 2012 19:03:59 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 3/3] EDAC: Convert AMD EDAC pieces to use RAS printk buffer |
| |
On Mon, Mar 12, 2012 at 04:59:37PM +0000, Luck, Tony wrote: > > Sounds better, especially the close-on-exit part. Please elaborate on > > the races... > > Errors are happening asynchronously to everything. Race looks like: > > Daemon exits (or is killed) > <<<< race begins here > kernel close routine called > close routine updates your global variable > <<<< race ends here
Well, in that case, we're going to miss logging a single error, or log it incomplete.
Unless, we make the global variable atomic and make the daemon zero it as the first action it does when it starts going away. If it is killed, then we probably need some sanity-checking functionality which checks periodically whether the daemon is still alive ...
This probably needs more meditation.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |