Messages in this thread | | | Subject | Re: [PATCH 1/4] jffs2: Convert most D1/D2 macros to jffs2_dbg | From | Joe Perches <> | Date | Mon, 12 Mar 2012 10:11:10 -0700 |
| |
On Mon, 2012-03-12 at 18:35 +0200, Artem Bityutskiy wrote: > On Mon, 2012-03-12 at 08:33 -0700, Joe Perches wrote: > > I tentatively converted them to a bitmap > > and a single jffs2_dbg(mask, fmt, ...) > > but perhaps all of these could be deleted > > too. > > I think it is better to convert them to jffs2_debug(). And I guess after > the change the "mask" parameter will go away?
Mask would remain and perhaps become a module variable instead of a compile #define.
What is jffs2_debug? Do you mean JFFS2_DEBUG? My intent was to remove JFFS2_<LEVEL> defines and uses. These #defines add "(%d) %s" ... task_pid_nr(current), __func__ which can be added if really necessary via pr_fmt to generic pr_<level> uses.
I am not certain of the value for generic uses of task_pid_nr in pr_notice,pr_err, or pr_info.
Dynamic debugging has the ability to optionally add task_pid_vnr and __func__ to pr_debug output.
| |