Messages in this thread | | | From | "Henrik Rydberg" <> | Date | Mon, 12 Mar 2012 14:02:33 +0100 | Subject | Re: [PATCH 1/5] HID: multitouch: add support for eGalax 0x722a |
| |
> > Thanks Jiri. > > How about patches 2,3 and 5? > > I just needed some more time to review those. They are now in my tree as > well. > > Patch #4 is still under discussion, and thus on hold.
I am ok with the approach, given that a better one would require a substantial amount of extra work. Also, since this is all internal changes, the current patchset does not hinder an eventual improvement later on. For patch 3, it would be good to at least put the test for the hid-multitouch driver in a separate function. For patch 4, the variable name "multitouch" is a bit too generic given the very specific usage.
Thanks, Henrik
| |