Messages in this thread | | | From | Linus Torvalds <> | Date | Thu, 1 Mar 2012 19:25:46 -0800 | Subject | Re: [PATCH] i8k: fix ioctl handing (was Re: Linux 3.3-rc5) |
| |
On Thu, Mar 1, 2012 at 7:26 AM, Mark Lord <kernel@teksavvy.com> wrote: > > I'm still not 100% happy with the arg/argp passing to i8ki_unlocked_ioctl() though. > Shouldn't there be a compat_ptr() macro in there someplace?
Yes, I think you should have "compat_ptr(arg)" there.
Patch looks good. And perhaps i8k_get_bios_version() should be renamed to "i8k_get_smm_bios_version()" to not cause this crazy confusion again.
Linus
| |