lkml.org 
[lkml]   [2012]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] i8k: fix ioctl handing (was Re: Linux 3.3-rc5)
On Thu, Mar 1, 2012 at 7:26 AM, Mark Lord <kernel@teksavvy.com> wrote:
>
> I'm still not 100% happy with the arg/argp passing to i8ki_unlocked_ioctl() though.
> Shouldn't there be a compat_ptr() macro in there someplace?

Yes, I think you should have "compat_ptr(arg)" there.

Patch looks good. And perhaps i8k_get_bios_version() should be renamed
to "i8k_get_smm_bios_version()" to not cause this crazy confusion
again.

Linus


\
 
 \ /
  Last update: 2012-03-02 04:29    [W:0.111 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site