Messages in this thread | | | Date | Thu, 1 Mar 2012 21:33:03 +0100 | Subject | Re: [PATCH 8/8] ARM: tegra: HACK: remove set_irq_flags() from driver | From | Linus Walleij <> |
| |
On Thu, Mar 1, 2012 at 8:26 PM, Alan Ott <alan@signal11.us> wrote:
> From: Arnd Bergmann <arnd@arndb.de> > > The driver should not call set_irq_flags itself, and > cannot do this from a loadable module. > > Remove the call for now, which might break the driver > but at least lets the kernel link again. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/usb/host/ehci-tegra.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c > index dbc7fe8..ab91f26 100644 > --- a/drivers/usb/host/ehci-tegra.c > +++ b/drivers/usb/host/ehci-tegra.c > @@ -729,7 +729,6 @@ static int tegra_ehci_probe(struct platform_device *pdev) > err = -ENODEV; > goto fail; > } > - set_irq_flags(irq, IRQF_VALID);
The kernel is full of this kind of stuff (drivers/mfd/twl4030-irq.c):
#ifdef CONFIG_ARM /* ARM requires an extra step to clear IRQ_NOREQUEST, which it * sets on behalf of every irq_chip. Also sets IRQ_NOPROBE. */ set_irq_flags(irq, IRQF_VALID); #else /* same effect on other architectures */ irq_set_noprobe(irq); #endif
Can't we try to fix this for real instead of breaking the universe, hehe :-)
Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |