Messages in this thread | | | Date | Thu, 9 Feb 2012 10:40:19 +0100 | From | Damien Wyart <> | Subject | Re: [PATCH] block: remove plugging at buffered write time |
| |
> > Done, thanks! Here is the updated patch with O_SYNC write fix.
> Got these errors with the updated patch on top of 3.3-rc3:
> fs/sync.c: In function 'vfs_fsync_range': > fs/sync.c:167:18: error: storage size of 'plug' isn't known > fs/sync.c:173:2: error: implicit declaration of function 'blk_start_plug' [-Werror=implicit-function-declaration] > fs/sync.c:175:2: error: implicit declaration of function 'blk_finish_plug' [-Werror=implicit-function-declaration] > fs/sync.c:167:18: warning: unused variable 'plug' [-Wunused-variable]
Adding a #include <linux/blkdev.h> at the top of fs/sync.c solved the problem. Of course, this needs approval of a kernel developper before being added to the patch and resubmitted because I know adding #includes can have unwanted consequences sometimes or be seen as bloat...
-- Damien Wyart
| |