lkml.org 
[lkml]   [2012]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Re: [PATCH v10 3.3-rc2 1/9] uprobes: Install and remove breakpoints.

* Srikar Dronamraju <srikar@linux.vnet.ibm.com> wrote:

> /* Clear REX.b bit (extension of MODRM.rm field):
> * we want to encode rax/rcx, not r8/r9.
> */

Small stylistic nit, just saw this chunk fly by - the proper
comment style is like this one:

> /*
> * Point cursor at the modrm byte. The next 4 bytes are the
> * displacement. Beyond the displacement, for some instructions,
> * is the immediate operand.
> */

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-02-09 08:57    [W:0.128 / U:3.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site