Messages in this thread | | | Date | Thu, 9 Feb 2012 19:33:46 +0400 | From | Anton Vorontsov <> | Subject | Re: [PATCH 3/8] arm: Fix possible race on task->mm |
| |
On Wed, Feb 08, 2012 at 05:08:08PM +0100, Oleg Nesterov wrote: > On 02/07, Anton Vorontsov wrote: > > > > Checking for task->mm is dangerous as ->mm might disappear (exit_mm() > > assigns NULL under task_lock(), so tasklist lock is not enough). > > > > We can't use get_task_mm()/mmput() pair as mmput() might sleep, > > Yes, but > > > so let's take the task lock while we care about its mm. > > it seems that this needs find_lock_task_mm() too ? > > the same for the rest patches in this series.
Yep, I think you're right, will add this change.
-- Anton Vorontsov Email: cbouatmailru@gmail.com
| |