lkml.org 
[lkml]   [2012]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] smsc95xx: add module parameter to turn off NIC status leds
From
From: Peter Meerwald <pmeerw@pmeerw.net>
Date: Wed, 8 Feb 2012 12:08:51 +0100

> From: Peter Meerwald <p.meerwald@bct-electronic.com>
>
> add module parameter to allow to turn off NIC status leds (link,
> speed, activity); blinking LEDs are annoying outside the server room :)
>
> default behaviour is not changed, tested on beagleboard-xm
>
> Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>

No. Create a generic mechanism, perhaps via ethtool, for users to
configure something like this.

Otherwise the next driver that wants to provide this kind of knob
will add yet another module parameter with yet another name, and
this kind of ad-hoc set of interfaces absolutely sucks for users.


\
 
 \ /
  Last update: 2012-02-08 21:29    [W:0.024 / U:2.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site