Messages in this thread | | | Date | Wed, 08 Feb 2012 15:26:24 -0500 (EST) | Subject | Re: [PATCH 1/2] smsc95xx: add module parameter to turn off NIC status leds | From | David Miller <> |
| |
From: Peter Meerwald <pmeerw@pmeerw.net> Date: Wed, 8 Feb 2012 12:08:51 +0100
> From: Peter Meerwald <p.meerwald@bct-electronic.com> > > add module parameter to allow to turn off NIC status leds (link, > speed, activity); blinking LEDs are annoying outside the server room :) > > default behaviour is not changed, tested on beagleboard-xm > > Signed-off-by: Peter Meerwald <p.meerwald@bct-electronic.com>
No. Create a generic mechanism, perhaps via ethtool, for users to configure something like this.
Otherwise the next driver that wants to provide this kind of knob will add yet another module parameter with yet another name, and this kind of ad-hoc set of interfaces absolutely sucks for users.
| |