lkml.org 
[lkml]   [2012]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] arch: net: bpf_jit_comp: Fixed coding style issues.
From
From: Mbarek Firas <mbarekfiras@gmail.com>
Date: Fri, 3 Feb 2012 01:38:15 +0100

> - COND_SEL(BPF_S_JMP_JGT_K, X86_JA, X86_JBE);
> - COND_SEL(BPF_S_JMP_JGE_K, X86_JAE, X86_JB);
> - COND_SEL(BPF_S_JMP_JEQ_K, X86_JE, X86_JNE);
> - COND_SEL(BPF_S_JMP_JSET_K,X86_JNE, X86_JE);
> - COND_SEL(BPF_S_JMP_JGT_X, X86_JA, X86_JBE);
> - COND_SEL(BPF_S_JMP_JGE_X, X86_JAE, X86_JB);
> - COND_SEL(BPF_S_JMP_JEQ_X, X86_JE, X86_JNE);
> - COND_SEL(BPF_S_JMP_JSET_X,X86_JNE, X86_JE);
> + COND_SEL(BPF_S_JMP_JGT_K, X86_JA, X86_JBE);
> + COND_SEL(BPF_S_JMP_JGE_K, X86_JAE, X86_JB);
> + COND_SEL(BPF_S_JMP_JEQ_K, X86_JE, X86_JNE);
> + COND_SEL(BPF_S_JMP_JSET_K, X86_JNE, X86_JE);

This is rediculious, it's not fixing anything.

There is no requirement that all the arguments have to line up
to the same column on every line.

I'm not applying this patch.


\
 
 \ /
  Last update: 2012-02-04 22:57    [W:0.031 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site