lkml.org 
[lkml]   [2012]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RESEND] ceph: avoid panic with mismatched symlink sizes in fill_inode()
From
Date
On Fri, 2012-02-03 at 09:55 -0500, Xi Wang wrote:
> Return -EINVAL rather than panic if iinfo->symlink_len and
> inode->i_size do not match.
>
> Also use kstrndup rather than kmalloc/memcpy.
>
> Signed-off-by: Xi Wang <xi.wang@gmail.com>

Looks good, though it might good to at least call
WARN_ON(). What do you think?

I will commit this (either with or without the
WARN_ON()).

Reviewed-by: Alex Elder <elder@dreamhost.com>




\
 
 \ /
  Last update: 2012-02-03 21:27    [W:0.033 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site