Messages in this thread | | | Subject | Re: [PATCH RESEND] ceph: avoid panic with mismatched symlink sizes in fill_inode() | From | Alex Elder <> | Date | Fri, 03 Feb 2012 14:24:32 -0600 |
| |
On Fri, 2012-02-03 at 09:55 -0500, Xi Wang wrote: > Return -EINVAL rather than panic if iinfo->symlink_len and > inode->i_size do not match. > > Also use kstrndup rather than kmalloc/memcpy. > > Signed-off-by: Xi Wang <xi.wang@gmail.com>
Looks good, though it might good to at least call WARN_ON(). What do you think?
I will commit this (either with or without the WARN_ON()).
Reviewed-by: Alex Elder <elder@dreamhost.com>
| |