Messages in this thread | | | Date | Fri, 3 Feb 2012 15:53:04 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH] Handling of unused variable 'do-numainfo on compilation time |
| |
On Fri 03-02-12 14:39:50, Johannes Weiner wrote: > Michal, this keeps coming up, please decide between the proposed > solutions ;-)
Hmm, I thought we already sorted this out https://lkml.org/lkml/2012/1/26/25 ?
> > On Fri, Feb 03, 2012 at 05:43:47PM +0900, Geunsik Lim wrote: > > Actually, Usage of the variable 'do_numainfo'is not suitable for gcc compiler. > > Declare the variable 'do_numainfo' if the number of NUMA nodes > 1. > > > > Signed-off-by: Geunsik Lim <geunsik.lim@samsung.com> > > --- > > mm/memcontrol.c | 5 ++++- > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 556859f..4e17ac5 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -776,7 +776,10 @@ static void memcg_check_events(struct mem_cgroup *memcg, struct page *page) > > /* threshold event is triggered in finer grain than soft limit */ > > if (unlikely(mem_cgroup_event_ratelimit(memcg, > > MEM_CGROUP_TARGET_THRESH))) { > > - bool do_softlimit, do_numainfo; > > + bool do_softlimit; > > +#if MAX_NUMNODES > 1 > > + bool do_numainfo; > > +#endif > > > > do_softlimit = mem_cgroup_event_ratelimit(memcg, > > MEM_CGROUP_TARGET_SOFTLIMIT); > > -- > > 1.7.8.1 > >
-- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic
| |