Messages in this thread | | | Date | Fri, 3 Feb 2012 09:08:34 -0500 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/2] mm: make do_writepages() use plugging |
| |
On Fri, Feb 03, 2012 at 09:38:23PM +0800, Wu Fengguang wrote: > On Fri, Feb 03, 2012 at 06:57:06PM +0530, Amit Sahrawat wrote: > > This will cover all the invocations for writepages to be called with > > plugging support. > > Thanks. I'll test it on the major filesystems. But would you > name a few filesystems that are expected to benefit from it? > It's not obvious because some FS ->writepages eventually calls > generic_writepages() which already does plugging.
Ant that's exactly where it should stay instead of beeing sprinkled all over the VM code.
NAK to the patch.
| |