Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [PATCH 2/3] x86, RAS: Add a decoded msg buffer | Date | Tue, 28 Feb 2012 22:43:52 +0000 |
| |
+ if (left <= 50) { + /* enlarge arbitrarily by 50 chars */ + err_str_sz += 50; + left += 50; + + err_str = krealloc(err_str, err_str_sz, GFP_KERNEL); + if (!err_str) { + pr_err("Error enlarging decode buffer.\n"); + return; + } + }
This looks worrying to me. Some bad stuff has happened, we are perhaps in machine check context, and you want to start allocating memory!
Is there some upper bound for how long this string can get? Why not just allocate a generous amount at boot time?
-Tony
| |