lkml.org 
[lkml]   [2012]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] checkpatch: do not try to sanity test cover letters
On Mon, Feb 27, 2012 at 04:50:11PM -0800, Joe Perches wrote:
> On Mon, 2012-02-27 at 19:47 -0500, Paul Gortmaker wrote:
> > On Mon, Feb 27, 2012 at 7:36 PM, Joe Perches <joe@perches.com> wrote:
> > > On Mon, 2012-02-27 at 19:29 -0500, Paul Gortmaker wrote:
> > >> One possibly common workflow is this:
> > >>
> > >> git format-patch -o mypatches --cover-letter ^start end
> > >> ./scripts/checkpatch.pl mypatches/*
> > >
> > > I use a script for this and don't put the check
> > > in checkpatch but put the check in bash.
> >
> > Sure, and I can do the same. But my question to you is whether
> > you think the above is a common workflow, and if the false positives
> > that it generates will decrease the number of people likely to make
> > using it a part of their routine?
>
> Dunno. I generally think that tools should report
> errors when the input given them is inappropriate.

Tend to agree, the more complex we make checkpatch the more often it
will be wrong. And it is wrong enough already.

-apw


\
 
 \ /
  Last update: 2012-02-28 16:41    [W:0.047 / U:1.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site