Messages in this thread | | | From | Santosh Y <> | Date | Mon, 27 Feb 2012 11:52:09 +0530 | Subject | Re: [PATCH v2 4/5] [SCSI] ufshcd: SCSI error handling |
| |
On Sun, Feb 26, 2012 at 10:16 AM, Hillf Danton <dhillf@gmail.com> wrote: > On Fri, Feb 24, 2012 at 3:19 PM, Santosh Y <santoshsy@gmail.com> wrote: >> +/** >> + * ufshcd_is_tmq_full - checks if the task management slots are full >> + * @hba: per adapter instance >> + * >> + * Returns maximum number of task management request slots in case of >> + * task management queue full or returns the free slot number >> + */ >> +static inline int ufshcd_is_tmq_full(struct ufs_hba *hba) > > This helper function is named to be misleading, little to do with > its functionality as full is checked at callsite.
ok, thanks, I'll change it.
> > -hd > >> +{ >> + return find_first_zero_bit(&hba->outstanding_tasks, hba->nutmrs); >> +} >> + > [...] >> + host = hba->host; >> + >> + spin_lock_irqsave(host->host_lock, flags); >> + >> + /* If task management queue is full */ >> + free_slot = ufshcd_is_tmq_full(hba); >> + if (free_slot >= hba->nutmrs) { >> + spin_unlock_irqrestore(host->host_lock, flags); >> + dev_err(&hba->pdev->dev, "Task management queue full\n"); >> + err = FAILED; >> + goto out; >> + }
-- ~Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |