Messages in this thread | | | Date | Mon, 27 Feb 2012 08:22:42 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] autofs4: fix compilation without CONFIG_COMPAT |
| |
On 02/27/2012 01:09 AM, Heiko Carstens wrote: > On Mon, Feb 27, 2012 at 08:29:25AM +0100, Christian Borntraeger wrote: >> On 26/02/12 02:31, Linus Torvalds wrote: >>> >>> +#else >>> + >>> +#define is_compat_task() (0) >>> + >> >> Linus, >> >> this breaks 32bit builds of s390 (and maybe others), since several platforms already >> define a is_compat_task. > > It breaks only !COMPAT builds on s390, since only we have the is_compat_task() > function defined for !COMPAT. The reason for that was simply to get rid of a > couple of ugly #ifdefs. > Note, that we still need to include asm/compat.h in some file since we need the > compat_ptr typedef. > That might be ugly, but I preferred including that header file so we could get > rid of the #ifdefs. > Anyway... the patch below fixes the build issues: >
This patch would seem to be The Right Thing; the combination of this really takes what s390 has done in arch space and globalizes it.
-hpa
| |