Messages in this thread | | | Date | Sun, 26 Feb 2012 18:51:34 +0100 | From | Bernhard Walle <> | Subject | Re: [PATCH] scripts/Kbuild.include: Fix portability problem of "echo -e" |
| |
Am 26.02.12 18:48, schrieb Sam Ravnborg: >> > --- a/scripts/Kbuild.include >> > +++ b/scripts/Kbuild.include >> > @@ -104,7 +104,7 @@ as-option = $(call try-run,\ >> > # Usage: cflags-y += $(call as-instr,instr,option1,option2) >> > >> > as-instr = $(call try-run,\ >> > - /bin/echo -e "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) >> > + printf "%b\n" "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3)) >> > >> > # cc-option >> > # Usage: cflags-y += $(call cc-option,-march=winchip-c6,-march=i586) > Roman Zippel removed use of printf in this patch: beda9f3a13bbb22cde92a45f230a02ef2afef6a9 > > I cannot remember why - but it would be good if you could dig up > why - just so we do not hit an old issue again.
Well, he used printf "$(1)", that's different from printf "%b\n" "$(1)" since format strings inside $(1) would be interpreted.
But maybe Roman can comment on that? Cc'ing him.
Regards, Bernhard
| |