lkml.org 
[lkml]   [2012]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/12] vmxnet3: check given MAC address, if invalid return -EADDRNOTAVAIL
    Date
    Check if given address is valid in .ndo_set_mac_address/
    vmxnet3_set_mac_addr(), if invalid return -EADDRNOTAVAIL as
    eth_mac_addr() already does if is_valid_ether_addr() fails.

    Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de>
    ---
    drivers/net/vmxnet3/vmxnet3_drv.c | 3 +++
    1 files changed, 3 insertions(+), 0 deletions(-)

    diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
    index e1562e8..bd2a7cd 100644
    --- a/drivers/net/vmxnet3/vmxnet3_drv.c
    +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
    @@ -2331,6 +2331,9 @@ vmxnet3_set_mac_addr(struct net_device *netdev, void *p)
    struct sockaddr *addr = p;
    struct vmxnet3_adapter *adapter = netdev_priv(netdev);

    + if (!is_valid_ether_addr(addr->sa_data))
    + return -EADDRNOTAVAIL;
    +
    memcpy(netdev->dev_addr, addr->sa_data, netdev->addr_len);
    vmxnet3_write_mac_addr(adapter, addr->sa_data);

    --
    1.7.8.3


    \
     
     \ /
      Last update: 2012-02-24 17:07    [W:4.436 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site