lkml.org 
[lkml]   [2012]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: Set delay to 0 if set_voltage_time_sel callback returns error
On Fri, Feb 24, 2012 at 03:17:46PM +0800, Axel Lin wrote:

> delay = rdev->desc->ops->set_voltage_time_sel(rdev,
> old_selector, selector);
> + if (delay < 0)
> + delay = 0;

We should complain if we get an error rather than silently ignore it,
possibly we'll end up returning prior to the ramp finishing which may
break things.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-02-24 15:55    [W:0.049 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site