Messages in this thread | | | Date | Thu, 23 Feb 2012 15:24:58 -0800 | From | Tejun Heo <> | Subject | Re: [PATCHSET] mempool, percpu, blkcg: fix percpu stat allocation and remove stats_lock |
| |
Hello, Andrew.
On Thu, Feb 23, 2012 at 03:22:23PM -0800, Andrew Morton wrote: > I forget how those patches work, but they might be vulnerable to the > same issue. If the block layer can handle the failed allocation > attempt and retry at the next I/O event then I guess that would be > acceptable; we'd lose a bit of statistical info occasionally, but who > cares. > > But ISTR that we can't handle allocation failures here?
It's just gonna skip percpu stats. The problem with percpu mempool is more about what __GFP_WAIT means in the interface. Handling alloc failure isn't difficult at all.
Thanks.
-- tejun
| |