Messages in this thread | | | Date | Thu, 23 Feb 2012 11:57:47 -0800 | From | Jesse Barnes <> | Subject | Re: [PATCH 5/7] PCI: Make pci bridge reallocating enabled/disabled |
| |
On Fri, 10 Feb 2012 15:33:50 -0800 Yinghai Lu <yinghai@kernel.org> wrote: > +enum enable_type { > + enable_not_set = -1, > + enable_no_user, > + enable_no_detected, > + enable_yes_user, > + enable_yes_detected, > +};
How about: user_enabled user_disabled auto_enabled auto_disabled ?
enable_no_* seems a bit confusing...
also the help text in kernel-parameters.txt should mention the config option and describe default behavior with and without that config option enabled.
Thanks, -- Jesse Barnes, Intel Open Source Technology Center [unhandled content-type:application/pgp-signature] | |