| Subject | [PATCH v3 03/21] memcg: fix page_referencies cgroup filter on global reclaim | From | Konstantin Khlebnikov <> | Date | Thu, 23 Feb 2012 17:51:51 +0400 |
| |
Global memory reclaimer shouldn't skip any page referencies.
This patch pass sc->target_mem_cgroup into page_referenced(). On global memory reclaim it always NULL, so we will account all. Cgroup reclaimer will account only referencies from target cgroup and its childs.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org> --- mm/vmscan.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c index 39aa4d7..d133ac6 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -701,13 +701,13 @@ enum page_references { }; static enum page_references page_check_references(struct page *page, - struct mem_cgroup_zone *mz, struct scan_control *sc) { int referenced_ptes, referenced_page; unsigned long vm_flags; - referenced_ptes = page_referenced(page, 1, mz->mem_cgroup, &vm_flags); + referenced_ptes = page_referenced(page, 1, + sc->target_mem_cgroup, &vm_flags); referenced_page = TestClearPageReferenced(page); /* Lumpy reclaim - ignore references */ @@ -828,7 +828,7 @@ static unsigned long shrink_page_list(struct list_head *page_list, } } - references = page_check_references(page, mz, sc); + references = page_check_references(page, sc); switch (references) { case PAGEREF_ACTIVATE: goto activate_locked; @@ -1735,7 +1735,8 @@ static void shrink_active_list(unsigned long nr_to_scan, continue; } - if (page_referenced(page, 0, mz->mem_cgroup, &vm_flags)) { + if (page_referenced(page, 0, + sc->target_mem_cgroup, &vm_flags)) { nr_rotated += hpage_nr_pages(page); /* * Identify referenced, file-backed active pages and
|