Messages in this thread | | | Date | Wed, 22 Feb 2012 14:14:41 -0200 | From | Rafael Aquini <> | Subject | Re: [PATCH] oom: add sysctl to enable slab memory dump |
| |
On Wed, Feb 22, 2012 at 07:55:16AM -0600, Christoph Lameter wrote: > > Please use node_nr_objects() instead of directly accessing total_objects. > total_objects are only available if debugging support was compiled in. > Shame on me! I've wrongly assumed that it would be safe accessing the element because SLUB_DEBUG is turned on by default when slub is chosen.
Considering your note on my previous mistake, shall I assume now that it would be better having this whole dump feature dependable on CONFIG_SLUB_DEBUG, instead of just CONFIG_SLUB ?
Thanks for your feedback! -- Rafael Aquini <aquini@redhat.com> Software Maintenance Engineer Red Hat, Inc. +55 51 4063.9436 / 8426138 (ext)
| |