lkml.org 
[lkml]   [2012]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 00/10] jump label: introduce very_[un]likely + cleanups + docs
From
Date
On Wed, 2012-02-22 at 08:54 -0500, Steven Rostedt wrote:
> But we could push a "unlikely(static_branch())" for
> such a case (or keep it as very_unlikely()).

If only that would work.. GCC assumes a bunch of things when you use
'asm goto'. An unbiased 'asm goto' that would take likely() and
unlikely() hints would be ideal, but alas that's not how the thing got
implemented.

Now arguable we could maybe just stick with the static_branch() thing
and decide that GCC is broken for adding bias and not respecting
likely() and unlikely(), but the GCC folks might have an opinion there.

Anyway, if we have to stick with the current implementation then an
unbiased version is impossible to implement.

If we get GCC folks on board to change stuff, who knows.


\
 
 \ /
  Last update: 2012-02-22 16:15    [W:0.091 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site