lkml.org 
[lkml]   [2012]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 12/19] ARM: at91/rtc-at91sam9: each SoC can select the RTT device to use
Date
On Wednesday 22 February 2012, Nicolas Ferre wrote:
> From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>
> For the RTT as RTC driver rtc-at91sam9, the platform_device structure
> is filled during SoC initialization. This will allow to convert this
> RTC driver as a standard platform driver.

Can you make this more elaborate? I don't see from this or the code why
you don't just always register the RTT as "rtc-at91sam9". There seems to
be no driver for the "at91_rtt" in tree, so I don't know if there is
an out of tree driver binding to it.

Would it be possible to remove the compile time #if and the resetting
of the device name if both drivers bind to the rtc name and the other
rtt driver binds to both names?

> static int __init at91_rtc_init(void)
> {
> - int status;
> - struct device *rtc;
> -
> - status = platform_driver_register(&at91_rtc_driver);
> - if (status)
> - return status;
> - rtc = bus_find_device(&platform_bus_type, NULL,
> - NULL, at91_rtc_match);
> - if (!rtc)
> - platform_driver_unregister(&at91_rtc_driver);
> - return rtc ? 0 : -ENODEV;
> + return platform_driver_register(&at91_rtc_driver);
> }
> module_init(at91_rtc_init);

This can become module_platform_driver().

Arnd


\
 
 \ /
  Last update: 2012-02-22 15:55    [W:0.197 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site