Messages in this thread | | | Date | Thu, 2 Feb 2012 14:36:02 -0800 | From | Josh Triplett <> | Subject | Re: [PATCH] checkpatch: Check for quoted strings broken across lines |
| |
On Thu, Feb 02, 2012 at 01:32:07PM -0800, Joe Perches wrote: > On Thu, 2012-02-02 at 13:28 -0800, Josh Triplett wrote: > > On Thu, Feb 02, 2012 at 12:36:29PM -0800, Joe Perches wrote: > > > On Thu, 2012-02-02 at 12:06 -0800, Josh Triplett wrote: > > > > Documentation/CodingStyle recommends not splitting quoted strings across > > > > lines, because it breaks the ability to grep for the string. checkpatch > > > > already makes an exception to the 80-column rule for quoted strings to > > > > allow this. Rather than just allowing it, actively warn about quoted > > > > strings split across lines. > [] > > > Seems sensible but there are also asm uses like: > > > arch/x86/include/asm/pvclock.h: "xor %5,%5 ; " > > > "add %4,%%eax ; " > > I did see those, yes. However, a quick grep through the kernel shows > > that those occur quite rarely compared to \n or \n\t; the latter looks > > like the standard style. How about I provide a patch for > > Documentation/CodingStyle adding a chapter on inline assembly, with that > > and other style guidelines? :) > > Sounds fine to me.
Done, with message-id <20120202223304.GA13069@leaf> and subject "[PATCH] Documentation/CodingStyle: Add guidelines for inline assembly".
- Josh triplett
| |