Messages in this thread | | | Date | Thu, 2 Feb 2012 13:27:50 +0000 | From | Mark Brown <> | Subject | Re: [RFC 2/7] MFD: twl6040: Convert to i2c driver, and separate it from twl core |
| |
On Thu, Feb 02, 2012 at 03:01:06PM +0200, Peter Ujfalusi wrote: > On 02/02/2012 02:48 PM, Mark Brown wrote:
> > The calling convention here seems a bit weird too, you've got value then > > register but normally we have register then value for I2C/SPI devices.
> I have based these part on the twl-core's implementation. I should not > have done that, I know.. Let's see how it will look like with regmap.
Yeah, like I say...
> > Except when we don't :(
...it's not like we've been consistent so far. I'm not that fussed either way, I probably wouldn't have mentioned it if I hadn't otherwise been commenting. [unhandled content-type:application/pgp-signature] | |