Messages in this thread | | | Date | Thu, 2 Feb 2012 14:33:22 +0200 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH 01/10] cgroups: add res_counter_write_u64() API |
| |
On Wed, Feb 01, 2012 at 04:37:41AM +0100, Frederic Weisbecker wrote: > +#if BITS_PER_LONG == 32 > +void res_counter_write_u64(struct res_counter *counter, int member, u64 val) > +{ > + unsigned long long *target; > + unsigned long flags; > + > + spin_lock_irqsave(&counter->lock, flags); > + target = res_counter_member(counter, member); > + *target = val;
Nitpick: What's the point to have temporary variable here?
> + spin_unlock_irqrestore(&counter->lock, flags); > +} > +#else > +void res_counter_write_u64(struct res_counter *counter, int member, u64 val) > +{ > + unsigned long long *target; > + > + target = res_counter_member(counter, member); > + *target = val;
Ditto.
> +} > +#endif
-- Kirill A. Shutemov
| |