lkml.org 
[lkml]   [2012]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH 1/2] ARM: dma-mapping: its array of pointer
From
Date
On Fri, 2012-02-17 at 18:39 +0530, Ajeet Yadav wrote:
> To be consistant with declaration and usage of
^^^^^^^^^^
Spelling mistake, should be 'consistent'

> consistent_pte it need to be an array of (pte *)
^^^^
Grammar mistake, should be 'needs'.

>
> Signed-off-by: Ajeet Yadav <ajeet.yadav.77@gmail.com>

The title of this patch is a bit vague, perhaps something like:
"ARM: dma-mapping: Fix the type used for consistent_pte size
calculation"

The actual patch looks correct.

--
Tixy

> ---
> arch/arm/mm/dma-mapping.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index 1aa664a..04bfa76 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -170,7 +170,7 @@ static int __init consistent_init(void)
> unsigned long base = consistent_base;
> unsigned long num_ptes = (CONSISTENT_END - base) >> PMD_SHIFT;
>
> - consistent_pte = kmalloc(num_ptes * sizeof(pte_t), GFP_KERNEL);
> + consistent_pte = kmalloc(num_ptes * sizeof(pte_t *), GFP_KERNEL);
> if (!consistent_pte) {
> pr_err("%s: no memory\n", __func__);
> return -ENOMEM;





\
 
 \ /
  Last update: 2012-02-18 17:11    [W:0.037 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site