Messages in this thread | | | Subject | Re: [PATCH 3/3] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err | From | Joe Perches <> | Date | Fri, 17 Feb 2012 22:30:25 -0800 |
| |
On Sat, 2012-02-18 at 09:25 +0300, Dan Carpenter wrote: > On Fri, Feb 17, 2012 at 09:39:36PM -0200, Jorgyano Vieira wrote: > > Replace the usage of BCMLOG_ERR with pr_err and remove the macro definition. > This needs a pr_fmt line so we can tell where the errors are coming > from. > #define pr_fmt(fmt) KBUILD_MODNAME ": %s:%d: " fmt, __func__, __LINE__
True. __func__ and __LINE__ are not generally useful though.
I suggest just #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
| |