Messages in this thread | | | Date | Sat, 18 Feb 2012 11:36:15 -0200 | Subject | Re: [PATCH 3/3] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err | From | Jorgyano vieira <> |
| |
> It's possible to add "%s...", __func__ to > the necessary uses. Adding it to the generic > is likely overkill. I agree with that.
> But is it really necessary anyway? > > Aren't those called via some specific notifier > such that the output would make sense given > some specific invalid input? Some messages like "Invalid Arg" and "Invalid len" really don't make sense as it is.
But I think that just adding __func__ to the necessary uses is enough. I will resend this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |