lkml.org 
[lkml]   [2012]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/3] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err
From
> It's possible to add "%s...", __func__ to
> the necessary uses.  Adding it to the generic
> is likely overkill.
I agree with that.

> But is it really necessary anyway?
>
> Aren't those called via some specific notifier
> such that the output would make sense given
> some specific invalid input?
Some messages like "Invalid Arg" and "Invalid len" really don't make
sense as it is.

But I think that just adding __func__ to the necessary uses is enough.
I will resend this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-02-18 14:39    [W:0.027 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site