Messages in this thread | | | Date | Sat, 18 Feb 2012 10:17:49 +0100 | From | Hans-Christian Egtvedt <> | Subject | Re: [PATCH 16/18] Atmel: move console default platform_device to serial driver |
| |
Around Fri 17 Feb 2012 18:50:08 +0100 or thereabout, Nicolas Ferre wrote: > From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> > > This variable spread on every SoC that is using the atmel_serial.c > driver can be included directly into the latter. > > This will allow to compile multiple soc in the same kernel.
Sounds like a good idea, but...
<snipp AT91 changes>
> diff --git a/arch/avr32/mach-at32ap/at32ap700x.c b/arch/avr32/mach-at32ap/at32ap700x.c > index 402a7bb..889c544 100644 > --- a/arch/avr32/mach-at32ap/at32ap700x.c > +++ b/arch/avr32/mach-at32ap/at32ap700x.c > @@ -1055,8 +1055,6 @@ struct platform_device *__init at32_add_device_usart(unsigned int id) > return at32_usarts[id]; > } > > -struct platform_device *atmel_default_console_device; > - > void __init at32_setup_serial_console(unsigned int usart_id) > { > atmel_default_console_device = at32_usarts[usart_id];
I doubt this assignment will work if you remove the struct above. I did not look at how AT91 does this, will it be similar affected?
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 10605ec..f9a6be7 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -1526,6 +1526,8 @@ void __init atmel_register_uart_fns(struct atmel_port_fns *fns) > atmel_pops.set_wake = fns->set_wake; > } > > +struct platform_device *atmel_default_console_device; /* the serial console device */ > + > #ifdef CONFIG_SERIAL_ATMEL_CONSOLE > static void atmel_console_putchar(struct uart_port *port, int ch) > { -- mvh Hans-Christian Egtvedt
| |