Messages in this thread | | | Subject | Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err | From | Joe Perches <> | Date | Sat, 18 Feb 2012 15:45:26 -0800 |
| |
On Sat, 2012-02-18 at 21:34 -0200, Jorgyano vieira wrote: > this is the output after the patch: > $ grep -rP --include=*.[ch] -m1 "^[ \t]*#[ \t]*include" [] > drivers/staging/crystalhd/crystalhd_lnx.c:#include "crystalhd_lnx.h"
So this is still 2 layers indirected.
It might make more sense to have a #include "crystalhd.h" have pr_fmt be the first #define in that and have crystalhd.h be the first #include in everything.
| |