Messages in this thread | | | Date | Fri, 17 Feb 2012 19:46:57 +0100 | Subject | Re: [PATCH] gpiolib: Add comments explaining the _cansleep() WARN_ON()s | From | Linus Walleij <> |
| |
On Fri, Feb 17, 2012 at 7:46 PM, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> I've seen users getting very confused by the WARN_ON()s for can_sleep > GPIOs in the atomic-safe paths, the discoverability of the non-atomic > version of the API seems to be hampered by the fact that it's defined > in a header file not the .c file where the warnings are. > > Add a couple of comments next to the warnings to help people on their > way. > > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thanks, Linus Walleij
| |