lkml.org 
[lkml]   [2012]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: amba: don't include <asm/sizes.h>
On Thu, Feb 16, 2012 at 05:05:25PM +0100, Alessandro Rubini wrote:
> The file uses no SZ_* symbol and some architectures miss sizes.h
>
> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
> Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@st.com>
> ---
>
> There a number of files including but not using it. This one
> in particular I need under x86 so the fix is trivial.
>
> However, I remember different feelings about sizes.h . Should it die
> or should it proliferate to other archs using asm-generic/sizes.h ?

It would be good to have it included for all architectures.
It really has nothing arch specific in it so it ought to live in
include/linux:

git mv include/asm-generic include/linux
And a fix for the archs that will be broken by this.
A small wrapper in arch/$ARCH/include/asm could do the trick


And speaking of this file I sometime have missed:
#define SZ_1K_BITS 10
#define SZ_2K_BITS 11

Or something similar.

Sam


\
 
 \ /
  Last update: 2012-02-16 18:29    [W:0.148 / U:1.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site