Messages in this thread | | | Date | Thu, 16 Feb 2012 14:35:39 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 3/3] KVM: perf: kvm events analysis tool |
| |
Em Wed, Feb 15, 2012 at 10:05:08PM -0700, David Ahern escreveu: > On 2/15/12 9:59 PM, Xiao Guangrong wrote: > > > > > >Okay, i will post the next version after collecting your new comments! > > > >Thanks for your time, David! :) > > > > I had more comments, but got sidetracked and forgot to come back to > this. I still haven't looked at the code yet, but some comments from > testing: > > 1. The error message: > Warning: Error: expected type 5 but read 4 > Warning: Error: expected type 5 but read 0 > Warning: unknown op '}' > > is fixed by this patch which has not yet made its way into perf: > https://lkml.org/lkml/2011/9/4/41 > > The most recent request: > https://lkml.org/lkml/2012/2/8/479 > > Arnaldo: the patch still applies cleanly (but with an offset of -2 lines).
I'll merge this one now, recall Steven asked me to, thanks for the reminder,
- Arnaldo
| |