Messages in this thread | | | Date | Wed, 15 Feb 2012 09:43:54 +0100 | From | Jesper Nilsson <> | Subject | Re: [PATCH 08/40] cris: Use set_current_blocked() and block_sigmask() |
| |
On Tue, Feb 14, 2012 at 12:40:41PM +0100, Matt Fleming wrote: > From: Matt Fleming <matt.fleming@intel.com> > > As described in e6fa16ab ("signal: sigprocmask() should do > retarget_shared_pending()") the modification of current->blocked is > incorrect as we need to check whether the signal we're about to block > is pending in the shared queue. > > Also, use the new helper function introduced in commit 5e6292c0f28f > ("signal: add block_sigmask() for adding sigmask to current->blocked") > which centralises the code for updating current->blocked after > successfully delivering a signal and reduces the amount of duplicate > code across architectures. In the past some architectures got this > code wrong, so using this helper function should stop that from > happening again. > > Cc: Oleg Nesterov <oleg@redhat.com> > Cc: Mikael Starvik <starvik@axis.com> > Cc: Jesper Nilsson <jesper.nilsson@axis.com>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
> Cc: linux-cris-kernel@axis.com > Signed-off-by: Matt Fleming <matt.fleming@intel.com>
/^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com
| |