Messages in this thread | | | From | Liu Qiang-B32616 <> | Subject | RE: [PATCH V2 RESEND] fsl-sata: I/O load balancing | Date | Wed, 15 Feb 2012 07:29:36 +0000 |
| |
> -----Original Message----- > From: linux-ide-owner@vger.kernel.org [mailto:linux-ide- > owner@vger.kernel.org] On Behalf Of Li Yang > Sent: Wednesday, February 15, 2012 3:22 PM > To: Liu Qiang-B32616 > Cc: jgarzik@pobox.com; linux-ide@vger.kernel.org; linuxppc- > dev@lists.ozlabs.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH V2 RESEND] fsl-sata: I/O load balancing > > On Wed, Feb 15, 2012 at 1:49 PM, Qiang Liu <qiang.liu@freescale.com> > wrote: > > Hi Liu Qiang, > > The patch is fine except for the title and comment. It's too vague to > say I/O load balancing. You need explicit description like "add > interrupt coalescing support" as title. > > > Reduce interrupt signals through reset Interrupt Coalescing Control Reg. > > Provide dynamic method to adjust interrupt signals and timer ticks by > sysfs. > > It is a tradeoff for different applications. > > How about: > > Adds support for interrupt coalescing feature to reduce interrupt events. > Provides mechanism of adjusting coalescing count and timeout tick by > sysfs on runtime, so that tradeoff of latency and CPU load can be made > depending on applications. > Ok, I will change the title and comments more specifically.
> - Leo > -- > To unsubscribe from this list: send the line "unsubscribe linux-ide" in > the body of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html
| |