Messages in this thread | | | Date | Wed, 15 Feb 2012 13:08:22 +0800 | Subject | Re: [PATCH v1] percpu: use raw_local_irq_* in _this_cpu op | From | Ming Lei <> |
| |
On Wed, Feb 15, 2012 at 12:59 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote: > Le mercredi 15 février 2012 à 12:36 +0800, Ming Lei a écrit : >> It doesn't make sense to trace irq off or do irq flags >> lock proving inside 'this_cpu' operations, so replace local_irq_* >> with raw_local_irq_* in 'this_cpu' op. > ... >> Acked-by: Christoph Lameter <cl@linux.com> >> Signed-off-by: Ming Lei <tom.leiming@gmail.com> >> --- >> include/linux/percpu.h | 20 ++++++++++---------- >> 1 files changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/include/linux/percpu.h b/include/linux/percpu.h >> index 6e68d05..5ed1e38 100644 >> --- a/include/linux/percpu.h >> +++ b/include/linux/percpu.h >> @@ -294,9 +294,9 @@ do { \ >> #define _this_cpu_generic_to_op(pcp, val, op) \ >> do { \ >> unsigned long flags; \ >> - local_irq_save(flags); \ >> + raw_local_irq_save(flags); \ >> *__this_cpu_ptr(&(pcp)) op val; \ >> - local_irq_restore(flags); \ >> + raw_local_irq_restore(flags); \ >> } while (0) >> > > Could you check the alignement of trailing '\' ?
Just several warnings, no errors. Also the 5 warnings are introduced by previous commit, sounds nothing to do with motivation of this patch. You may prepare a standalone patch to fix all the code style in this file, :-)
./script/checkpatch.pl WARNING: line over 80 characters ...... total: 0 errors, 5 warnings, 60 lines checked
thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |