Messages in this thread | | | Date | Tue, 14 Feb 2012 09:48:35 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 2/9] ARM: at91/snapper9260: move gpio_to_irq out of structure initialization |
| |
On Tue, Feb 14, 2012 at 07:02:20AM +1100, Ryan Mallon wrote: > On 14/02/12 01:43, Nicolas Ferre wrote: > > > gpio_to_irq() implementation will be moved from a macro to a > > plain function: we cannot use it in a structure initialization > > anymore. > > What was the reason for the change? It was originally a macro for > exactly this reason.
gpio_to_irq() is supposed to work not only for built-in GPIOs, but also GPIOs provided by other devices. Having it as a definition which only works for the SoC GPIOs is broken.
| |