Messages in this thread | | | Date | Tue, 14 Feb 2012 21:33:06 -0500 | From | Christoph Hellwig <> | Subject | Re: [PATCH -v2 3/3] xfs: cleanup quota check on disk blocks and inodes reservations |
| |
On Mon, Feb 06, 2012 at 09:51:05PM +0900, Mitsuo Hayasaka wrote: > This patch is a cleanup of quota check on disk blocks and inodes > reservations, and changes it as follows. > > (1) add a total_count variable to store the total number of > current usages and new reservations for disk blocks and inodes, > respectively. > > (2) make it more readable to check if the local variables softlimit > and hardlimit are positive. It has been changed as follows. > if (softlimit > 0ULL) -> if (softlimit) > if (hardlimit > 0ULL) -> if (hardlimit) > This is because they are defined as xfs_qcnt_t which is unsigned. > > Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com> > Cc: Ben Myers <bpm@sgi.com> > Cc: Alex Elder <elder@kernel.org> > Cc: Christoph Hellwig <hch@lst.de>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |