lkml.org 
[lkml]   [2012]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 01/31] events/hw_event: Create a Hardware Events Report Mecanism (HERM)
Em 12-02-2012 16:44, Borislav Petkov escreveu:
> On Sun, Feb 12, 2012 at 03:21:42PM -0200, Mauro Carvalho Chehab wrote:
>> As I said before, there's just one trace call for memory error events
>> (hw_event:mc_error) on my second RFC.
>
> Are you kidding me:
>
> $ grep -EriIno "trace_.*\W" patch01.txt
>
> ...
>
> TRACE_EVENT(mc_corrected_error,
> TRACE_EVENT(mc_uncorrected_error,
> TRACE_EVENT(mc_corrected_error_fbd,
> TRACE_EVENT(mc_uncorrected_error_fbd,
> TRACE_EVENT(mc_out_of_range,
> TRACE_EVENT(mc_corrected_error_no_info,
> TRACE_EVENT(mc_uncorrected_error_no_info,
>

Huh?

See PATCH v3 03/31: hw_event: Consolidate uncorrected/corrected error msgs into one

Those events got merged there into one hardware event and one
software error event generated due to a hardware trouble
(mc_out_of_range).

This patch:
[PATCH v3 21/31] hw_event: Add x86 MCE events on it

adds the mc_error_mce variant per your request.

What is there is:

$ grep TRACE_EVENT include/trace/events/hw_event.h
TRACE_EVENT(mc_error,
TRACE_EVENT(mc_out_of_range,
TRACE_EVENT(mc_error_mce,
TRACE_EVENT(mc_out_of_range_mce,

And what I've said already is that I'll get rid of
"mc_out_of_range_mce" in the final version, and convert
"mc_out_of_range" into a generic event to inform that a hardware
error occurred but the driver has a bug and weren't able to
parse it.

I only added:
TRACE_EVENT(mc_error_mce,
per your request to have an arch-specific event with both mce-record
data and mc_error information.

For me, only this hardware-error event is needed:
TRACE_EVENT(mc_error,

Subsequent patches consolidate the drivers to just use one function
call to EDAC core to report the errors:
edac_mc_handle_error()

That function increments the error counts, gets the associated
label(s) and generate the event. It currently also prints the error
message, to preserve backward compatibility.

Mauro.


\
 
 \ /
  Last update: 2012-02-12 20:41    [W:0.062 / U:1.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site