Messages in this thread | | | Date | Sun, 12 Feb 2012 13:11:05 +0000 | From | Mark Brown <> | Subject | Re: [PATCH V4 2/2] regmap: add regmap_bulk_write() for register write |
| |
On Sun, Feb 12, 2012 at 12:57:25PM +0100, Lars-Peter Clausen wrote: > On 02/12/2012 09:49 AM, Laxman Dewangan wrote: > > [...] > > + } else { > > + for (i = 0; i < val_count; i++) { > > + memcpy(&ival, val + (i * val_bytes), val_bytes);
> This will have endianess issues. You'll need something like regcache_get_val.
> > + ret = _regmap_write(map, reg + i, ival);
Or just don't provide this fallback at all - it's not something the underlying device supports anyway and none of the other block or bulk operations work on these devices either. [unhandled content-type:application/pgp-signature] | |