Messages in this thread | | | Date | Sat, 11 Feb 2012 12:56:19 +0100 | From | Stefan Richter <> | Subject | Re: [PATCH 2/3] firewire-sbp2: Ignore SBP-2 targets on the local node |
| |
On Feb 10 Chris Boot wrote: > --- a/drivers/firewire/sbp2.c > +++ b/drivers/firewire/sbp2.c > @@ -1138,6 +1138,12 @@ static int sbp2_probe(struct device *dev) > struct Scsi_Host *shost; > u32 model, firmware_revision; > > + /* ignore targets on the local node */ > + if (device->node == device->card->local_node) { > + dev_set_drvdata(&unit->device, NULL); > + return 0; > + }
I forgot: This test can yield false negatives because card->local_node may change anytime. Check device->is_local instead. -- Stefan Richter -=====-===-- --=- -=-== http://arcgraph.de/sr/
| |