Messages in this thread Patch in this message | | | Subject | [PATCH 1/5] x86/cpu: Fix overrun check in arch_print_cpu_modalias() | From | Ben Hutchings <> | Date | Sat, 11 Feb 2012 22:46:17 +0000 |
| |
snprintf() does not return a negative value when truncating.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk> --- arch/x86/kernel/cpu/match.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/match.c b/arch/x86/kernel/cpu/match.c index 940e2d4..2dfa52b 100644 --- a/arch/x86/kernel/cpu/match.c +++ b/arch/x86/kernel/cpu/match.c @@ -67,7 +67,7 @@ ssize_t arch_print_cpu_modalias(struct device *dev, for (i = 0; i < NCAPINTS*32; i++) { if (boot_cpu_has(i)) { n = snprintf(buf, size, ",%04X", i); - if (n < 0) { + if (n >= size) { WARN(1, "x86 features overflow page\n"); break; } -- 1.7.9
| |