Messages in this thread | | | Date | Sun, 9 Dec 2012 18:53:15 +0100 | From | Michal Marek <> | Subject | Re: [PATCH v2 2/2] scripts/tags.sh: Support compiled source |
| |
On Tue, Dec 04, 2012 at 03:04:33AM +0900, Joonsoo Kim wrote: > We usually have interst in compiled files only, > because they are strongly related to individual's work. > Current tags.sh can't select compiled files, so support it. > > We can use this functionality like below. > "make cscope O=. SRCARCH=xxxx COMPILED_SOURCE=compiled" > > It must be executed after building the kernel. > > Signed-off-by: Joonsoo Kim <js1304@gmail.com> > --- > v2: change bash specific '[[]]' to 'case in' statement. > use COMPILED_SOURCE env var, instead of abusing SUBARCH
Looks much better, I have only one minor nitpick:
> + if [ "$COMPILED_SOURCE" = "compiled" ]; then > + all_compiled_sources
Please change it to -n "$COMPILED_SOURCE", so that COMPILED_SOURCE=1 works as well.
Michal
| |