lkml.org 
[lkml]   [2012]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/video/wm8505fb.c: use devm_ functions
> Rather than the goto, add the fail path code in directly, and return.
>
>
> ret = register_framebuffer(&fbi->fb);
> if (ret < 0) {
> dev_err(&pdev->dev,
> "Failed to register framebuffer device: %d\n", ret);
> if (fbi->fb.cmap.len)
> fb_dealloc_cmap(&fbi->fb.cmap);
> return ret;
> }

So there is no need for the platform_set_drvdata(pdev, NULL); ?

Also, do you know if it is correct that the original code does not include
a call to dma_free_coherent?

thanks,
julia


\
 
 \ /
  Last update: 2012-12-09 08:41    [W:0.368 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site