Messages in this thread | | | Date | Sun, 9 Dec 2012 08:21:33 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [PATCH] drivers/video/wm8505fb.c: use devm_ functions |
| |
> Rather than the goto, add the fail path code in directly, and return. > > > ret = register_framebuffer(&fbi->fb); > if (ret < 0) { > dev_err(&pdev->dev, > "Failed to register framebuffer device: %d\n", ret); > if (fbi->fb.cmap.len) > fb_dealloc_cmap(&fbi->fb.cmap); > return ret; > }
So there is no need for the platform_set_drvdata(pdev, NULL); ?
Also, do you know if it is correct that the original code does not include a call to dma_free_coherent?
thanks, julia
| |